[bazel] Allow manufactoring code to be used by downstream repos. #29000
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothytrippel
approved these changes
Dec 23, 2025
pamaury
reviewed
Dec 25, 2025
|
|
||
| load("@//rules:manuf.bzl", "device_id_header") | ||
| load("@//rules:signing.bzl", "offline_presigning_artifacts", "offline_signature_attach") | ||
| load("@lowrisc_opentitan//rules:manuf.bzl", "device_id_header") |
Contributor
There was a problem hiding this comment.
Why not just //rules:manuf.bzl, i.e. dropping the @ entirely? Unless this file is used outside of the lowRISC repository, it is not necessary to specifiy the repo name.
Contributor
There was a problem hiding this comment.
it is used outside this repo.
Contributor
|
please fix the lint errors |
Use the module name '@lowrisc_opentitan' instead of '@' when referencing targets in the same workspace. This is the approach recommended by https://bazel.build/external/migration#specify-repo-name and allows manufactoring code (e.g. perso_tlv_data) to be used in downstream repos that use the opentitan repo as a submodule. Change-Id: I30401894b71a230e3144f9ec564d42a170e3218e Signed-off-by: Jason Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the module name '@lowrisc_opentitan' instead of '@' when referencing targets in the same workspace. This is the approach recommended by https://bazel.build/external/migration#specify-repo-name and allows manufactoring code (e.g. perso_tlv_data) to be used in downstream repos that use the opentitan repo as a submodule.
Change-Id: I30401894b71a230e3144f9ec564d42a170e3218e