Update path-data-polyfill.js #322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request addresses issue #321, where certain SVG path data was not being parsed correctly, leading to rendering issues in the whiteboard application. The root cause was identified in the outdated path-data-polyfill.js file. This PR replaces it with an updated version from jarek-foksa/path-data-polyfill commit 115f8ab, which includes improved path parsing logic and bug fixes.
Update path-data-polyfill.js
lovasoa
requested changes
Apr 4, 2025
Owner
lovasoa
left a comment
lovasoa
left a comment
There was a problem hiding this comment.
Hi ! Did you test your changes ? They do not seem to fix the issue, for me.
Author
|
Hi! Thanks for your feedback. I’m a bit confused, since the exact same code was committed shortly after my PR was submitted and marked as 'not working'. Could you clarify why the commit was accepted, but the PR was not? Thanks! |
Owner
|
No, the upstream was updated with the required fix after you pulled it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #321, where certain SVG path data was not being parsed correctly, leading to rendering issues in the whiteboard application. The root cause was identified in the outdated path-data-polyfill.js file. This PR replaces it with an updated version from jarek-foksa/path-data-polyfill commit 115f8ab, which includes improved path parsing logic and bug fixes.
By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.