environment variable WBO_MAX_BOARD_SIZE_X to give max width of board (closes #118) #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aximum width of board (closes lovasoa#118)
lovasoa
reviewed
Sep 25, 2020
lovasoa
requested changes
Sep 25, 2020
Owner
lovasoa
left a comment
lovasoa
left a comment
There was a problem hiding this comment.
This looks good, I'm ready to merge that. I agree that getting rid of the uneditable blank spaces is worth it, even if it is an inconvenience on screens with an unusual aspect ratio.
Owner
|
Can you have a look at the failing tests too ? |
Contributor
Author
|
It looks like the failing tests assume a given transformation matrix, which is getting broken by my code that sets the minimum zoom level. On second thought, it seems odd that the max scaling should be reached, unless either the window is very big in the test, or the max board size is small... |
Co-authored-by: Ophir LOJKINE <pere.jobs@gmail.com>
Co-authored-by: Ophir LOJKINE <pere.jobs@gmail.com>
Co-authored-by: Ophir LOJKINE <pere.jobs@gmail.com>
Owner
|
It looks like the cursor element (to which the transform should be applied) is not even present |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added a configuration variable MAX_BOARD_SIZE_X. I also made
By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.board.jsobey the existingMAX_BOARD_SIZE(which it wasn't), and made it so you can't zoom out beyond the width of the board. The latter isn't technically necessary, and could in cases of a very wide window be annoying, but I think it's better than letting users confuse themselves with a bunch of white space that they can't write on.