Fix legacy firmware (2.x) response format in invoke()#355
Open
StevenEmelander wants to merge 1 commit intoloopj:mainfrom
Open
Fix legacy firmware (2.x) response format in invoke()#355StevenEmelander wants to merge 1 commit intoloopj:mainfrom
StevenEmelander wants to merge 1 commit intoloopj:mainfrom
Conversation
StevenEmelander
force-pushed
the
fix/legacy-firmware-valueerror
branch
from
556f2de to
06bc11c
Compare
StevenEmelander
changed the title
StevenEmelander
force-pushed
the
fix/legacy-firmware-valueerror
branch
2 times, most recently
from
00b946f to
40d741d
Compare
StevenEmelander
changed the title
Legacy firmware omits the method name from invoke() responses. Handle this by treating it as optional instead of required.
StevenEmelander
force-pushed
the
fix/legacy-firmware-valueerror
branch
from
40d741d to
75c666c
Compare
StevenEmelander
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Legacy Vantage InFusion firmware (2.x) omits the method name from
invoke()responses:The current code requires the method name via tuple unpacking, causing a
ValueErrorthat crashes controller initialization.Fix
Treat the echoed method name as optional instead of required. The method name was already unused (discarded as
_method) since the caller already knows what method was invoked.No behavior change for modern firmware.
Fixes #354