-
Notifications
You must be signed in to change notification settings - Fork 0
Feature: Edge Node Device Status Tracking #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Edge Node Device Status Tracking #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements edge node device status tracking functionality using HybridCache to efficiently track and manage the online/offline status of edge nodes and their associated devices within a Sparkplug-based system.
Key Changes:
- Added
StatusTrackingServicethat tracks online/offline status with timestamp-based conflict resolution - Introduced
CacheHelperutility for building cache keys and managing semaphores for thread-safe operations - Comprehensive test suite validating status transitions, concurrent updates, and edge node-device relationships
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| SparklerNet/SparklerNet.csproj | Added Microsoft.Extensions.Caching.Hybrid package dependency |
| SparklerNet/HostApplication/Caches/StatusTrackingService.cs | Core implementation of status tracking with online/offline state management and timestamp-based updates |
| SparklerNet/HostApplication/Caches/IStatusTrackingService.cs | Interface defining status tracking operations for edge nodes and devices |
| SparklerNet/HostApplication/Caches/IMessageOrderingService.cs | Minor documentation update to standardize parameter description |
| SparklerNet/HostApplication/Caches/CacheHelper.cs | Utility class for cache key building and semaphore management |
| SparklerNet.Tests/HostApplication/Caches/StatusTrackingServiceTests.cs | Comprehensive test suite covering status tracking scenarios including concurrent updates |
| SparklerNet.Tests/HostApplication/Caches/CacheHelperTests.cs | Unit tests for cache key building and semaphore management |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SparklerNet.Tests/HostApplication/Caches/StatusTrackingServiceTests.cs
Outdated
Show resolved
Hide resolved
SparklerNet.Tests/HostApplication/Caches/StatusTrackingServiceTests.cs
Outdated
Show resolved
Hide resolved
SparklerNet.Tests/HostApplication/Caches/StatusTrackingServiceTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SparklerNet.Tests/HostApplication/Caches/StatusTrackingServiceTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SparklerNet.Tests/HostApplication/Caches/StatusTrackingServiceTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR implements edge node device status tracking functionality.