feat(solid): add solid.js logto sdk#949
Conversation
|
@yefu24324 you may need to run |
| export const baseUrl = window.location.origin; | ||
| export const redirectUrl = `${baseUrl}/callback`; | ||
|
|
||
| export const appId = 'hi9w1eijf2nlnuz88xjt6'; // Register the sample app in Logto dashboard |
There was a problem hiding this comment.
we can replace them with env variables.
There was a problem hiding this comment.
Or just consts with fake ID, like in the other samples. Not a big deal, though.
| export default function Callback() { | ||
| const navigate = useNavigate(); | ||
| const { isLoading } = useHandleSignInCallback(() => { | ||
| console.log("???") |
There was a problem hiding this comment.
It would be better to replace with more friendly message or delete it.
|
Hey @yefu24324, thank you for your contribution. We're really excited to see your PR. While we are reviewing the code, could you please also complete the steps to sign your commits? You can follow the GitHub official guide and let us know if you have questions. |
Okay, I need to learn GPG, |
3 participants
Summary
add solid.js logto sdk
Testing
Local preview.
Checklist
.changesetI referenced React and rewrote the SDK for SolidJS. Please let me know if there are any issues with the code