Open
Conversation
|
Bump cc @jordansissel @danhermann This is a very simple fix and something I needed today |
patrobinson
pushed a commit
to envato-archive/logstash-input-tcp
that referenced
this pull request
Dec 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Several months ago I came across an issue. Let's assume this is my configuration:
If my certificate is actually signed by a real certificate authority, then I have to provide the entire CA-bundle in order for the cert to match the key. However, if I do not want my certificate to be actually verified in peer mode (I'm debugging, and using a server with a different hostname), if I disable such verification, then it essentially the same as if I did not even provide
ssl_extra_chain_certsargument.My pull request fixes this logic. So in case you have to provide a ca-bundle separately from your cert file and disable
ssl_verify, you now can.