fix: Add condition to check hostCpu and then build based on that

[Khushboo-dev-cpp]

This PR is needed to make sure libsds.dylib is built with the proper architecture on any macos machine

[Ivansete-status]

Thanks for it! 🙌
I just added a tiny question so far

[Ivansete-status]

Are we expecting this attribute to be adapted manually?

[Khushboo-dev-cpp]

its a constant coming from nim

[Ivansete-status]

Interesting! I wasn't aware of that :D

[alexjba]

I had to add the isysroot as well..No idea why it's not being picked automatically.

This made it work for me:

diff --git a/sds.nimble b/sds.nimble
index c683f4a..d1b43f4 100644
--- a/sds.nimble
+++ b/sds.nimble
@@ -1,5 +1,7 @@
 mode = ScriptMode.Verbose
 
+import strutils
+
 # Package
 version = "0.1.0"
 author = "Waku Team"
@@ -64,8 +66,9 @@ task libsdsDynamicMac, "Generate bindings":
   let name = "libsds"
 
   let arch = hostCPU
-  let archFlags = (if arch == "arm64": "--cpu:arm64 --passC:\"-arch arm64\" --passL:\"-arch arm64\""
-                   else: "--cpu:amd64 --passC:\"-arch x86_64\" --passL:\"-arch x86_64\"")
+  let sdkPath = staticExec("xcrun --show-sdk-path").strip()
+  let archFlags = (if arch == "arm64": "--cpu:arm64 --passC:\"-arch arm64\" --passL:\"-arch arm64\" --passC:\"-isysroot " & sdkPath & "\" --passL:\"-isysroot " & sdkPath & "\""
+                   else: "--cpu:amd64 --passC:\"-arch x86_64\" --passL:\"-arch x86_64\" --passC:\"-isysroot " & sdkPath & "\" --passL:\"-isysroot " & sdkPath & "\"")
 
   buildLibrary outLibNameAndExt,
     name, "library/",
@@ -91,9 +94,11 @@ task libsdsStaticLinux, "Generate bindings":
 task libsdsStaticMac, "Generate bindings":
   let outLibNameAndExt = "libsds.a"
   let name = "libsds"
+  let sdkPath = staticExec("xcrun --show-sdk-path").strip()
+  let sdkFlags = "--passC:\"-isysroot " & sdkPath & "\" --passL:\"-isysroot " & sdkPath & "\""
   buildLibrary outLibNameAndExt,
     name, "library/",
-    """-d:chronicles_line_numbers --warning:Deprecated:off --warning:UnusedImport:on -d:chronicles_log_level=TRACE """,
+    sdkFlags & " -d:chronicles_line_numbers --warning:Deprecated:off --warning:UnusedImport:on -d:chronicles_log_level=TRACE",
     "static"
 
 # Build Mobile iOS

[Khushboo-dev-cpp]

Hey status-im/status-app#19537 this change from Sid seems to solve the issue on macOS for me

[alexjba]

I guess the tricky question is why this PR is fixing the sds build? And why isn't it working out of the box without forcing the USE_SYSTEM_NIM?

[Khushboo-dev-cpp]

Yes exactly, there is an issue with this standalone library too, just building it on its own, complies it for x86_64, even on arm systems

[Ivansete-status]

Hi @alexjba , that's interesting
Thanks for the comments!
Kindly submit a separate PR with the fixes for .a
Cheers

[Ivansete-status]

LGTM! Thanks so much indeed for it and the patience! 🥳