Skip to content

Conversation

@PardeepSinghBali
Copy link
Contributor

What does this change?

with previous code , address drop down was working only for 1 dropdown in a form.
this fix will let user to add as many address field sets to add and each will have its own address dropdown populated w.r.t to address being searched

How to test

add Two or more different Address Field sets or one can duplicate the existing one.
search the address and see the addresses being populated in the respective dropdown

How can we measure success?

We can track how often the address dropdown is populated, especially the "No addresses found" or successful address options, and compare it to previous behavior before the fix.

Have we considered potential risks?

Images

Accessibility

@siliconmeadow
Copy link
Member

siliconmeadow commented Mar 14, 2025

@PardeepSinghBali - if you read through the thread at #110, you'll see discussion about #325 of LGD base which was identified as what caused it to be broken in the first place. And furthermore, when you look at that issue, it's suggested that this issue with Drupal core is the real culprit.

Could you do some evaluations of those issues and see if resolving at that level would fix this issue as well as other places where unspecified form elements might be assigned conflicting IDs? It could be this PR is merely treating the symptom rather than addressing and fixing the root cause.

@finnlewis finnlewis marked this pull request as draft March 18, 2025 12:28
@finnlewis
Copy link
Member

Thanks for this @PardeepSinghBali !

@Adnan-cds mentioned this in Merge Tuesday too. We'll convert to draft for now while we discuss and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants