Conversation
Co-authored-by: benjamin.kitt <benjamin.kitt@lob.com>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: Code Samples Outdated Across Multiple Languages
The Elixir and C# code samples in resources/addresses/addresses.yml still use the old address values. This creates an inconsistency with the updated examples for other languages in the same file.
resources/us_verifications/us_verifications.yml#L237-L247
lob-openapi/resources/us_verifications/us_verifications.yml
Lines 237 to 247 in 224cfb9
resources/addresses/addresses.yml#L453-L458
lob-openapi/resources/addresses/addresses.yml
Lines 453 to 458 in 224cfb9
| address_line1: 210 KING ST STE 6100 | ||
| address_city: SAN FRANCISCO | ||
| address_line1: 42 EXAMPLE RD STE 6100 | ||
| address_city: ANYTOWN |
There was a problem hiding this comment.
Bug: Inconsistent Address Data Across Resources
Address examples across various resources are inconsistent. address_city and address_zip were updated (e.g., 'Anytown, 02134'), but address_state often remains 'CA'. Additionally, many response examples retain the original address_line1 ('210 King St'). This mixes old and new address components, creating invalid address combinations in both request and response examples.
Additional Locations (13)
resources/addresses/addresses.yml#L466-L472resources/addresses/addresses.yml#L499-L505resources/letters/responses/letter.yml#L17-L36resources/postcards/responses/postcard.yml#L20-L72resources/addresses/responses/post_address.yml#L24-L29resources/addresses/responses/post_address.yml#L60-L63resources/addresses/responses/all_addresses.yml#L31-L41resources/self_mailers/responses/self_mailer.yml#L17-L19resources/letters/responses/all_letters.yml#L55-L57resources/postcards/responses/all_postcards.yml#L37-L39resources/checks/responses/check.yml#L22-L24resources/snap_packs/responses/snap_pack.yml#L16-L35resources/booklets/responses/all_booklets.yml#L37-L116
| address_line1: 42 EXAMPLE RD STE 6100 | ||
| address_line2: null | ||
| address_city: SAN FRANCISCO | ||
| address_city: ANYTOWN |
There was a problem hiding this comment.
Bug: Address State Mismatch Causes Inconsistency
Several address examples were updated to 'ANYTOWN' (city) and '02134' (zip), but the address_state field often remains 'CA'. This creates inconsistent and invalid addresses by mixing Massachusetts city/zip with a California state.
Additional Locations (4)
2 participants
Fixes #
Checklist
mainnpm run bundleoutputs nothing suspectnpm run postmanoutputs nothing suspectChanges
Updated all example addresses from the old office address (e.g.,
210 King St, San Francisco, CA 94107) to a fake address (e.g.,42 Example Road, Anytown, MA 02134) across the OpenAPI documentation and resource files. This prevents accidental mail from being sent to an outdated address. Existing address formatting, such as suite numbers, was preserved.Areas of Concern (optional)
Postman JSON files were not updated as they are generated artifacts.