-
Notifications
You must be signed in to change notification settings - Fork 42
Change Hyphens to Underscores to Match Spack1.0 Syntax #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
c7b63c1 to
8183cec
Compare
|
I thought this would work but |
|
Update: this PR is waiting until @scheibelp gets a chance to take a look. |
bbaba94 to
6cfa837
Compare
|
dryruns should at least be passing now (I tested locally). Not sure about gitlab tests |
… the isort version and local run wants something different
…sed repo locations)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1091 +/- ##
========================================
Coverage 64.45% 64.45%
========================================
Files 48 48
Lines 3618 3618
Branches 273 273
========================================
Hits 2332 2332
Misses 1277 1277
Partials 9 9
🚀 New features to boost your workflow:
|
michaelmckinsey1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve in github as an author, but I approve anyway
Description
Adding/modifying a benchmark (docs: Adding a Benchmark)
repo/*