Skip to content

Conversation

@michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Sep 25, 2025

Description

  • Spack package naming syntax changed from "-" to "_" in spack1.0, so updating our package names.

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • repo/*

@michaelmckinsey1
Copy link
Collaborator Author

I thought this would work but

==> Warning: while setting up external spec cray-mpich@=9.0.1+gtl+wrappers %[email protected]: No such variant 'gtl' in package cray-mpich
==> Error: No such variant 'gtl' in package cray-mpich

@github-actions github-actions bot added application experiment New or modified experiment ci CI, unit tests, GitHub actions system New or modified system config labels Sep 25, 2025
@michaelmckinsey1 michaelmckinsey1 added the WIP A work-in-progress not yet ready to commit label Sep 29, 2025
@michaelmckinsey1 michaelmckinsey1 changed the title Change Hyphens to Underscores to Match Spack1.0 Syntax [WIP] Change Hyphens to Underscores to Match Spack1.0 Syntax Sep 29, 2025
@michaelmckinsey1
Copy link
Collaborator Author

Update: this PR is waiting until @scheibelp gets a chance to take a look.

@michaelmckinsey1 michaelmckinsey1 changed the title [WIP] Change Hyphens to Underscores to Match Spack1.0 Syntax Change Hyphens to Underscores to Match Spack1.0 Syntax Jan 6, 2026
@michaelmckinsey1 michaelmckinsey1 removed the WIP A work-in-progress not yet ready to commit label Jan 6, 2026
@michaelmckinsey1
Copy link
Collaborator Author

dryruns should at least be passing now (I tested locally). Not sure about gitlab tests

@github-actions github-actions bot added the feature New feature or request label Jan 6, 2026
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jan 27, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.45%. Comparing base (524fc9a) to head (a3b6dc0).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1091   +/-   ##
========================================
  Coverage    64.45%   64.45%           
========================================
  Files           48       48           
  Lines         3618     3618           
  Branches       273      273           
========================================
  Hits          2332     2332           
  Misses        1277     1277           
  Partials         9        9           
Files with missing lines Coverage Δ
lib/benchpark/experiment.py 87.90% <100.00%> (ø)
lib/benchpark/test/caliper.py 97.43% <100.00%> (ø)
repos/ramble_applications/saxpy/application.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator Author

@michaelmckinsey1 michaelmckinsey1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve in github as an author, but I approve anyway

@pearce8 pearce8 marked this pull request as draft January 31, 2026 05:29
@pearce8 pearce8 marked this pull request as ready for review January 31, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application ci CI, unit tests, GitHub actions dependencies Pull requests that update a dependency file experiment New or modified experiment feature New feature or request system New or modified system config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants