Fix delete_installed_embedding to reset embedding to initial value #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting the last embedding from a library, the embedding field was
being set to an empty list [] instead of the initial "no embedding" value.
This caused subsequent operations like installing new embeddings to fail.
This fix ensures that when all embeddings are deleted, the embedding field
is reset to the initial value:
[{"embedding_status": "no", "embedding_model": "none", "embedding_db": "none",
"embedded_blocks": 0, "embedding_dims": 0, "time_stamp": "NA"}]
Fixes llmware-ai#1094
Signed-off-by: majiayu000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[]instead of initial value when deleting last embeddingTest plan
_update_embedding_record_handlermethodFixes #1094
Signed-off-by: majiayu000 [email protected]