Conversation
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
| toolgroups=["builtin::rag"], | ||
| tool_choice="auto", | ||
| tool_prompt_format="json", | ||
| tool_prompt_format="python_list", |
There was a problem hiding this comment.
You should be able to just remove this since we added llamastack/llama-stack#1214
There was a problem hiding this comment.
I see, thank you! I will update it asap
BTW: is there any way to be informed of the ongoing/planned changes before pushing PRs that are already out-of-date? 😬
There was a problem hiding this comment.
I don't know if there's a better way but I just look at open PRs periodically and check github notifications.
BTW I do plan to do a full clean up of tool_prompt_format as well.
There was a problem hiding this comment.
BTW: I tried to remove the prompt format but resolve_model fails to resolve the model so the default prompt is still json 😞
These are the models I'm using:
% llama-stack-client models list
Available Models
┏━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ model_type ┃ identifier ┃ provider_resource_id ┃ metadata ┃ provider_id ┃
┡━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ embedding │ all-MiniLM-L6-v2 │ all-minilm:latest │ {'embedding_dimension': │ ollama │
│ │ │ │ 384.0} │ │
├────────────┼──────────────────┼──────────────────────┼──────────────────────────┼─────────────┤
│ llm │ llama3.2:1b │ llama3.2:1b │ │ ollama │
└────────────┴──────────────────┴──────────────────────┴──────────────────────────┴─────────────┘
Total models: 2Changing the check to compare lower-cased strings seems to work, but I'm not sure it may break something else:
for m in all_registered_models():
if descriptor.lower in (m.descriptor().lower(), m.huggingface_repo):
return m
return NoneThere was a problem hiding this comment.
ollama run llama3.2:1b, is that wrong?
There was a problem hiding this comment.
anyhow llamastack/llama-stack#1360 should fix this
There was a problem hiding this comment.
I will try again and clear the setting.
There was a problem hiding this comment.
confirm that it works w/ the default format
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>

What does this PR do?
Closes #195
Feature/Issue validation/testing/test plan
Start llama-stack server, then:
Before submitting
Pull Request section?
to it if that's the case.
Thanks for contributing 🎉!