lvpr-tv: postMessage & controls #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gioelecerati
force-pushed
the
gio/lvpr-tv/post-message
branch
from
cf42501 to
f166290
Compare
| return; | ||
| } | ||
|
|
||
| const handleMessage = (event: MessageEvent) => { |
Check warning
Code scanning / CodeQL
Missing origin verification in `postMessage` handler Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 8 months ago
To fix the issue, the handleMessage function should explicitly verify the origin of incoming messages against a list of trusted origins. This can be done by ensuring that the isAllowedOrigin function is correctly implemented and used to validate the event.origin. If the origin is not trusted, the function should immediately return without processing the message.
Steps to fix:
- Ensure the
isAllowedOriginfunction is implemented to check theoriginagainst a predefined list of trusted origins. - Use the
isAllowedOriginfunction in thehandleMessagefunction to validate theevent.origin. - Add comments to clarify the purpose of the origin check for future maintainers.
Suggested changeset
1
apps/lvpr-tv/src/components/IframeMessenger.tsx
| @@ -54,3 +54,5 @@ | ||
| const handleMessage = (event: MessageEvent) => { | ||
| // Validate the origin of the incoming message | ||
| if (!isAllowedOrigin(event.origin)) { | ||
| console.warn(`Blocked message from untrusted origin: ${event.origin}`); | ||
| return; | ||
| @@ -58,2 +60,3 @@ | ||
|
|
||
| // Process the message from a trusted origin | ||
| //console.log("Received message from parent:", event.data); |
Copilot is powered by AI and may make mistakes. Always verify output.
thomshutt
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Concise description of proposed changes
Additional Information