feat(voice): reuse STT connection across agent handoffs#5093
Open
feat(voice): reuse STT connection across agent handoffs#5093
Conversation
toubatbrian
reviewed
Mar 12, 2026
| if self.stt is None or new_activity.stt is None: | ||
| return False | ||
| return ( | ||
| type(self.agent).stt_node is type(new_activity.agent).stt_node |
Contributor
There was a problem hiding this comment.
Should we also check for tts, vad, as well as other configurations?
Contributor
Author
There was a problem hiding this comment.
vad is always updated, the tts and llm streams are created per turn so no need to reuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #4123