feat/sarvam-llm-openai-compatible-integration#5069
Open
dhruvladia-sarvam wants to merge 4 commits intolivekit:mainfrom
Open
feat/sarvam-llm-openai-compatible-integration#5069dhruvladia-sarvam wants to merge 4 commits intolivekit:mainfrom
dhruvladia-sarvam wants to merge 4 commits intolivekit:mainfrom
Conversation
…models.py Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
| "Programming Language :: Python :: 3 :: Only", | ||
| ] | ||
| dependencies = ["livekit-agents[codecs]>=1.4.5", "numpy>=1.26"] | ||
| dependencies = ["livekit-agents[codecs, openai]>=1.4.4", "numpy>=1.26"] |
Contributor
There was a problem hiding this comment.
🟡 Minimum dependency version lowered from >=1.4.5 to >=1.4.4 inconsistently with all other plugins
The livekit-agents minimum version was lowered from >=1.4.5 to >=1.4.4 in this PR. Every other plugin in the monorepo (including livekit-plugins-openai at livekit-plugins/livekit-plugins-openai/pyproject.toml:25) and every extras entry in livekit-agents/pyproject.toml:63-118 specifies >=1.4.5. This inconsistency could allow installation of livekit-agents==1.4.4 whose openai extra definition may differ from the current version, potentially pulling in an incompatible livekit-plugins-openai version that lacks features the sarvam plugin depends on.
Suggested change
| dependencies = ["livekit-agents[codecs, openai]>=1.4.4", "numpy>=1.26"] | |
| dependencies = ["livekit-agents[codecs, openai]>=1.4.5", "numpy>=1.26"] |
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llmmodule, with model support forsarvam-30bandsarvam-105b.openai.LLM.with_sarvam(...)so Sarvam can be used like other OpenAI-compatible providers.Why
livekit.plugins.sarvam.LLM(...)livekit.plugins.openai.LLM.with_sarvam(...)Files changed
livekit-plugins/livekit-plugins-sarvam/livekit/plugins/sarvam/llm/__init__.pylivekit-plugins/livekit-plugins-sarvam/livekit/plugins/sarvam/llm/client.pylivekit-plugins/livekit-plugins-sarvam/livekit/plugins/sarvam/llm/models.pylivekit-plugins/livekit-plugins-sarvam/livekit/plugins/sarvam/__init__.pylivekit-plugins/livekit-plugins-sarvam/pyproject.tomllivekit-plugins/livekit-plugins-sarvam/README.mdlivekit-plugins/livekit-plugins-openai/livekit/plugins/openai/llm.pylivekit-plugins/livekit-plugins-openai/livekit/plugins/openai/models.pyValidation / testing performed
from livekit.plugins import sarvam, openaiopenai.LLM.with_sarvam(...)availability and usagesarvam-30b,sarvam-105b) for:tool_choice:none,auto,required)temperature,top_p,reasoning_effort,seed,stop,n,frequency_penalty,presence_penalty,max_tokens,wiki_grounding)duration,completion_tokens,prompt_tokens,prompt_cached_tokens,total_tokens,tokens_per_second,ttft,speech_id).Notes
speech_idis expected to benullin direct standalonellm.chat(...).collect()tests; it is populated in fullAgentSessionvoice flow context.