feat: remove database validation overhead and fix Ctrl+C cancellation in QueryCommand#62
Merged
feat: remove database validation overhead and fix Ctrl+C cancellation in QueryCommand#62
Conversation
… discovery process
…rformance and user experience
operations - Pass CancellationToken to ParallelOptions in QueryCommand - Remove OperationCanceledException from Polly retry conditions - Await writer task with cancellation to prevent hanging after cancel - Update specs and design docs for new cancellation behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryCommandto eliminate unnecessary connection overhead before query execution; discovery now happens once during the parallel execution phaseCtrl+Ccancellation not stopping in-flight queries: passcts.Tokento the outerParallel.ForEachAsyncParallelOptionsso the token propagates correctly through both server and database loops down to NpgsqlOperationCanceledExceptionfrom Polly'sShouldHandlepredicate — intentional cancellations were being silently retried up to 3 times (causing ~3.5s delay afterCtrl+C); onlyNpgsqlExceptionandTimeoutExceptionare now retriedWaitAsync(cts.Token)to prevent the process from hanging indefinitely after cancellationpublish.bat(replaced bypublish.ps1)winget-publish.ps1Test coverage