Skip to content

Conversation

@City-busz
Copy link

This makes it consistent with the client-side decoration of GTK.
Also, fix scaling of the icon.

This makes it consistent with the client-side decoration of GTK.
Also, fix scaling of the icon.
@clefebvre clefebvre changed the title theme.c: Use window icon for the menu button if available [Next] theme.c: Use window icon for the menu button if available Jan 7, 2026
@clefebvre clefebvre changed the title [Next] theme.c: Use window icon for the menu button if available theme.c: Use window icon for the menu button if available Jan 22, 2026
int x, y;

width = cairo_image_surface_get_width (surface) / scale;
height = cairo_image_surface_get_height (surface) / scale;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only thought about this because I ran into different surface types somewhere else...

mini_icon can potentially be a cairo_xlib_surface (though it's very unlikely), but we should probably use cairo_surface_get_type() and use the the correct get_width/get_height functions.

See https://github.com/linuxmint/muffin/blob/master/src/x11/iconcache.c#L340-L365 (if !mask)

@mtwebster
Copy link
Member

I was looking at gtk and their headerbar code, and the 'menu' decorator option isn't for the standard window-manager menu there, it's for an application menu - it means two different things.

I'm not sure using the app icon makes sense for the button on server-decorated windows, other than 'because we can'.

I'm having trouble even finding an app that calls gtk_application_set_app_menu() in the first place - every client-decorated app I've tried ignores the 'menu' decorator.

@JosephMcc
Copy link
Contributor

Using the app icon doesn't make sense at all. That certainly wouldn't make it consistent. In fact, I'm not sure why this button should even be supported in the server side decorations. It would just be a placeholder for the right click window menu. I honestly don't see anything "consistent" about having this button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants