FIX: keyboard layout switching while search is focused (#13428) #13473
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#13428) Previously, when the menu search entry was focused, keyboard layout switching via keybindings (e.g., Alt+Shift, Super+Space) would not work. The key event was stopped but the keybinding callback was never invoked. This fix: - Invokes the keybinding callback before stopping event propagation - Allows modifier-only keys to propagate for XKB-based layout switching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13428
Keyboard layout switching doesn't work when the menu search field is focused. Keybindings like Alt+Shift or Super+Space have no effect because the search entry's key event handler stops event propagation.
The fix has two parts:
This allows users to switch keyboard layouts while typing in the menu search field.