FIX: Add default home folders to search results (#13402) #13471
+74
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default home folders (Downloads, Documents, Pictures, Music, Videos, Desktop, Home) are now searchable in the menu regardless of sidebar visibility settings. The show* settings only control sidebar display, not search availability. - Add PlaceSearchResultButton class for place search results - Add _searchablePlaces array containing all default places - Search places independently of sidebar visibility settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13402
Users expect to find default home folders (Downloads, Documents, Pictures, Music, Videos, Desktop, Home) when searching in the menu, but currently they only appear if they're enabled in the sidebar settings.
This fix separates search functionality from sidebar visibility. Default home folders are now always searchable regardless of the show* settings. The settings only control whether folders appear in the sidebar, not whether they're searchable.
Changes: