Skip to content

FIX: Restore "Open with" context menu for recent/favorite files #13454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carsteneu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX: Restore "Open with" context menu for recent/favorite files #13454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 60 additions & 1 deletion files/usr/share/cinnamon/applets/[email protected]/applet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ class PathButton extends SimpleMenuItem {
description: shorten_path(uri, name),
type: type,
styleClass: 'appmenu-application-button',
withMenu: false,
withMenu: (type === 'recent' || type === 'favorite'),
uri: uri,
});

Expand Down Expand Up @@ -827,6 +827,65 @@ class PathButton extends SimpleMenuItem {
source.notify(notification);
}
}

hasLocalPath(file) {
return file.is_native() || file.get_path() != null;
}

populateMenu(menu) {
if (this.type !== 'recent' && this.type !== 'favorite')
return;

let menuItem;
menuItem = new PopupMenu.PopupMenuItem(_("Open with"), { reactive: false });
menuItem.actor.style = "font-weight: bold";
menu.addMenuItem(menuItem);

let file = Gio.File.new_for_uri(this.uri);
let mimeType = Gio.content_type_guess(this.uri, null)[0];

let default_info = Gio.AppInfo.get_default_for_type(mimeType, !this.hasLocalPath(file));

if (default_info) {
menuItem = new PopupMenu.PopupMenuItem(default_info.get_display_name());
menuItem.connect('activate', () => {
default_info.launch([file], null);
this.applet.toggleContextMenu(this);
this.applet.menu.close();
});
menu.addMenuItem(menuItem);
}

let infos = Gio.AppInfo.get_all_for_type(mimeType);

for (let i = 0; i < infos.length; i++) {
let info = infos[i];

if (!this.hasLocalPath(file) && !info.supports_uris())
continue;

if (info.equal(default_info))
continue;

menuItem = new PopupMenu.PopupMenuItem(info.get_display_name());
menuItem.connect('activate', () => {
info.launch([file], null);
this.applet.toggleContextMenu(this);
this.applet.menu.close();
});
menu.addMenuItem(menuItem);
}

if (GLib.find_program_in_path("nemo-open-with") != null) {
menuItem = new PopupMenu.PopupMenuItem(_("Other application..."));
menuItem.connect('activate', () => {
Util.spawnCommandLine("nemo-open-with " + this.uri);
this.applet.toggleContextMenu(this);
this.applet.menu.close();
});
menu.addMenuItem(menuItem);
}
}
}

class CategoryButton extends SimpleMenuItem {
Expand Down