Simplify cinnamon-menu-editor #13362
Open
+791
−1,134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcw
force-pushed
the
simplifymenueditor
branch
from
14be7eb to
5d12935
Compare
cinnamon-menu-editor: Remove item cut/copy/paste from menu editor and add menu category selection to desktop editor instead so that instead of the menu editor adding <Include> and <Exclude> rules to the .menu file when launchers are added to/remove from categories, the desktop editor adds/removes categories to the Categories= field in the .desktop file. Remove code related to separators and menu layout/ordering as these are not used in cinnamon applets. Add "Restore Item" button and remove "Close" button. Handle flatpak apps properly cinnamon-desktop editor: Add menu category selection for launcher editor. Add "Hide (NoDisplay)" toggle for launcher editor and directory editor. Remove unnecessary <Include> and <Exclude> rules from the .menu file added in previous versions of menu-editor when a .desktop file is updated. config.py: delete unused constants cinnamon-applications.menu: simplify logic in "Administration" menu remove unused "System" menu
fredcw
force-pushed
the
simplifymenueditor
branch
from
4b3f7f1 to
c2bbfe7
Compare
fredcw
changed the title
…iginal is in a subdirectory of... ... ~/.local/share/applications as the one in the subdirectory would just override it anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cinnamon-menu-editor:
Remove item cut/copy/paste from menu editor and add menu category selection to desktop editor instead so that instead of the menu editor adding <Include> and <Exclude> rules to the .menu file when launchers are added to/removed from categories, the desktop editor adds/removes categories to the Categories= field in the .desktop file.
Remove code related to separators and menu layout/ordering as these are not used in cinnamon applets.
Add "Restore Item" button and remove "Close" button.
Handle flatpak apps properly.
cinnamon-desktop editor:
Add menu category selection for launcher editor.
Add "Hide (NoDisplay)" toggle for launcher editor and directory editor.
Remove unnecessary <Include> and <Exclude> rules from the .menu file added in previous versions of menu-editor when a .desktop file is updated.
config.py:
delete unused constants
cinnamon-applications.menu:
simplify logic in "Administration" menu
remove unused "System" menu
Fixes #12890, #11998, #10139, #10581, #10141, #9293, #7961
Replaces: #13346
Known issues:
Some combinations of categories are not possible. An app can't be in Education and Science at the same time, in Universal Access and Preferences at the same time, or in Accessories or Preferences and Administration at the same time. This was not previously the case.
While Wine apps can be added to other categories, they cannot be removed from the Wine category as Wine creates it's own .menu file with <Include>'s.
Apps installed locally have no "Restore" (to system default) option once edited. This was previously the case also. This includes Wine apps, Steam games, Chrome's PWAs