Skip to content

Add night theme switcher to color plugin#448

Open
hans-fritz-pommes wants to merge 21 commits intolinuxmint:masterfrom
hans-fritz-pommes:master
Open

Add night theme switcher to color plugin#448
hans-fritz-pommes wants to merge 21 commits intolinuxmint:masterfrom
hans-fritz-pommes:master

Conversation

@hans-fritz-pommes
Copy link

I am trying to add a theme switcher to the color plugin - the color plugin is managing the night light, so it has the relevant settings and the functions for calculating the time and requirement checks to activate the night theme at the same time

@hans-fritz-pommes
Copy link
Author

hans-fritz-pommes commented Mar 16, 2026

To Do:

  • schedule_to in night_mode_recheck et night_theme_recheck et night_light_recheck
  • find solution for test-ccm with the not anymore used schedule-mode-automatic setting-key
  • rename the settings keys to night-mode-schedule-mode etc?
  • remove the file cs_themes.py (it is just a template for me)

@anaximeno
Copy link

Looks a bit overkill here, besides, if the goal is a way to switch between night/day themes, there's already this nice applet: https://cinnamon-spices.linuxmint.com/applets/view/397

@hans-fritz-pommes
Copy link
Author

Well, I didn't know this applet yet ¯_(ツ)_/¯ - it's really nice.
Anyway: I still think it would be a nice feature. In the cinnamon-settings, there is the section "night-mode": It has one point to set: The night light. Don't you think it would be nice having the built-in-comfort of a night theme switcher - which you can activate under the light with one click?

@hans-fritz-pommes hans-fritz-pommes marked this pull request as ready for review March 18, 2026 16:09
@hans-fritz-pommes
Copy link
Author

Can / should the keys night-light-schedule-from, night-light-schedule-to, night-light-last-coordinates and night-light-schedule-mode get renamed to "mode" instead of "light"?

@hans-fritz-pommes
Copy link
Author

In the ccm-self-test-file, night-light-schedule was set using a non-existing night-mode-schedule-automatic-key (already before my idea). This should be updated to use the night-light-schedule-mode-enum, right? But then the enum values (in C) have to be defined somewhere else than in csd-night-mode.c, otherwise the ccm-file would have no access to them.

@hans-fritz-pommes
Copy link
Author

hans-fritz-pommes commented Mar 18, 2026

In the meson.build-file, there are two sources = files (-sections. Why?

@hans-fritz-pommes hans-fritz-pommes changed the title [WIP] Add night theme switcher to color plugin Add night theme switcher to color plugin Mar 18, 2026
@hans-fritz-pommes
Copy link
Author

By the way: I am encountering a problem with the night light:
(not because of my changes - also when using the default package 6.6.3+zena)
Two users, night light active for both, time based activation (auto/manual). User 2 logs in.
User 1 logs in, waits till the light is switched completely on (2700K), logs out
User 2 logs in: Night light is (most times, maybe not always) inactive

Getting night-light temperature via dbus: 2700K, active: true
Should I open a new issue for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants