Skip to content

Conversation

@samarthsinh2660
Copy link
Contributor

Description

Refactors the LfxDeltaDisplay component to use a more flexible unit-based approach for durations, replacing the boolean isDuration flag with deltaUnit.

Changes

  • LfxDeltaDisplay: Replaced isDuration prop with deltaUnit (of type FormatterUnits).
  • Types: Updated DeltaDisplayProps to include deltaUnit and remove isDuration.
  • Logic: Updated component logic to use deltaUnit when calling formatSecondsToDuration.
  • Consumers: Updated MedianTimeToClose and MedianTimeToReview widgets to use the new delta-unit prop.
  • Stories: Updated Storybook configuration for LfxDeltaDisplay to reflect prop changes.
  • CI: Added pull-requests: write and statuses: write permissions to pr-title-lint.yml to resolve "Resource not accessible by integration" errors in CI.

Verification

  • pnpm tsc-check passed.
  • Verified that duration-based deltas are still formatted correctly in the widgets.

@samarthsinh2660 samarthsinh2660 force-pushed the fix/delta-display-refactor branch from 299e540 to 998ecf2 Compare January 9, 2026 14:23
@samarthsinh2660 samarthsinh2660 force-pushed the fix/delta-display-refactor branch from 998ecf2 to 6494d06 Compare January 9, 2026 14:38
@gaspergrom
Copy link
Collaborator

Hey, I will close this one as we are currently not yet opened for contributions (https://github.com/linuxfoundation/insights/blob/main/README.md) and there is no way for you to test your changes

@gaspergrom gaspergrom closed this Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants