Skip to content

Conversation

@samarthsinh2660
Copy link
Contributor

Description

Refactors filter types in the server-side data layer to eliminate redundancy and improve maintainability.

Changes

  • Type Inheritance: Updated all filter types in server/data/types.ts to inherit from DefaultFilter.
  • Cleanup: Removed redundant fields (project, repos, startDate, endDate) from specialized filter types like ActiveContributorsFilter, MergeLeadTimeFilter, MedianTimeToCloseFilter, etc.
  • TODO Resolution: Addressed the TODO note in server/data/types.ts regarding filter type refactoring.

Verification

  • pnpm tsc-check passed in the frontend directory.
  • Verified that all server-side API handlers still correctly type-check with the refactored filters.

@samarthsinh2660 samarthsinh2660 force-pushed the fix/server-api-todo-fixes branch from 7b4bed7 to ea80524 Compare January 9, 2026 14:22
@samarthsinh2660 samarthsinh2660 force-pushed the fix/server-api-todo-fixes branch from ea80524 to 9439ee2 Compare January 9, 2026 14:38
@gaspergrom
Copy link
Collaborator

Hey, I will close this one as we are currently not yet opened for contributions (https://github.com/linuxfoundation/insights/blob/main/README.md) and there is no way for you to test your changes

@gaspergrom gaspergrom closed this Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants