Skip to content

ci: update header for run_role_with_clear_facts [citest_skip]#857

Merged
richm merged 1 commit intomainfrom
ci-update-run_role
Apr 8, 2026
Merged

ci: update header for run_role_with_clear_facts [citest_skip]#857
richm merged 1 commit intomainfrom
ci-update-run_role

Conversation

@richm
Copy link
Copy Markdown
Contributor

@richm richm commented Apr 8, 2026

Update header for run_role_with_clear_facts to indicate not editable
and clarify what it does

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Clarify documentation header for the run_role_with_clear_facts test task file and mark it as managed by automation.

Documentation:

  • Update the header comments for run_role_with_clear_facts to describe its behavior more accurately and remove outdated output information.

Chores:

  • Mark the run_role_with_clear_facts task file as not manually editable because it is managed by linux-system-roles/.github tooling.

Update header for run_role_with_clear_facts to indicate not editable
and clarify what it does

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm self-assigned this Apr 8, 2026
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 8, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the header comments in the run_role_with_clear_facts test task file to mark it as managed/uneditable and to more accurately describe its behavior (clearing facts and running the network role, no longer saving/restoring facts).

File-Level Changes

Change Details Files
Clarify and correct the task file documentation for the run_role_with_clear_facts helper and mark it as auto-managed/uneditable.
  • Add a management notice indicating the file is maintained by linux-system-roles/.github and should not be edited directly.
  • Update the description to state that the task file clears facts and runs the linux-system-roles.network role, removing references to saving/restoring facts.
  • Simplify the include usage comment by removing the requirement about tests/library being in the module search path.
  • Remove the outdated documentation about ansible_facts output being merged with saved facts.
tests/tasks/run_role_with_clear_facts.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 6e5f706 into main Apr 8, 2026
16 checks passed
@richm richm deleted the ci-update-run_role branch April 8, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant