ci: fix yum repos to use devel site instead of old site name [citest_skip]#200
Merged
ci: fix yum repos to use devel site instead of old site name [citest_skip]#200
Conversation
…skip] Some of the older Testing Farm machines refer to the old site name in the yum repos. Ensure that they use the correct site name. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts CI configuration to use a compatible Codecov GitHub Action version and touches the parallel playbook testing plan metadata. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The PR description about fixing yum repos on Testing Farm machines doesn’t match the actual change (Codecov action version bump/downgrade); consider updating the description or including the yum-related changes so the intent is clear.
- Double-check that moving from
codecov/codecov-action@v6to@v5is intentional and aligns with the recommended/compatible version for this repo, since it appears to be a downgrade.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR description about fixing yum repos on Testing Farm machines doesn’t match the actual change (Codecov action version bump/downgrade); consider updating the description or including the yum-related changes so the intent is clear.
- Double-check that moving from `codecov/codecov-action@v6` to `@v5` is intentional and aligns with the recommended/compatible version for this repo, since it appears to be a downgrade.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the older Testing Farm machines refer to the old site name in the yum repos.
Ensure that they use the correct site name.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
CI: