Add as_impl_view methods to check that view builders have the right bounds #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e right bounds. This doesn't change what programs will compile, but tends to make error messages shorter and more informative.
Contributor
|
What kind of change occurs to error messages with this change? Can you give an example? Also |
Contributor
Author
I couldn't find a good name, but that's pretty good, thanks! |
xStrom
reviewed
Dec 16, 2025
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Looks fine, but needs a rebase now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change which programs will compile, but tends to make error messages shorter and more informative.