Remove thiserror dependency
#94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuzzles
approved these changes
Jan 14, 2026
nicoburns
force-pushed
the
remove-thiserror
branch
from
2f64e8a to
f3bbf4d
Compare
Signed-off-by: Nico Burns <[email protected]>
nicoburns
force-pushed
the
remove-thiserror
branch
from
f3bbf4d to
a10f8fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
thiserrordidn't really feel like it was pulling it's weight. This PR removes it in favour of manual trait impls.Although I've realised that as
velatodepends onserde(and thus pulls insyn/proc_macro2) anyway, we don't gain all that much from this.Putting it up anyway as I've written, but feel free to close.