-
Notifications
You must be signed in to change notification settings - Fork 21
Convert velato to use anyrender instead than vello
#92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e00d252 to
c559133
Compare
nuzzles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally like this change but one snag I don't really love is that it seems like anyrender_vello needs to be updated prior to velato? No longer just Vello, we would have a new obstacle in the middle.
Unless I'm misunderstanding.
nuzzles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs change log update
Correct, but that should be quick. I have an AnyRender update for Vello 0.7 ready to go once the Sparse Strips variants of Vello drop (should be tomorrow). The upside is that if the version of |
|
I think this might need a broader discussion. Please wait before landing. |
waywardmonkeys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want a broader discussion.
There was some prior discussion in #74 (comment) |
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
|
Closing in favour of #95 |
…95) Supercedes #92 as there was pushback about the use of AnyRender --------- Signed-off-by: Nico Burns <[email protected]>
Motivation
Allows
velatoto be used with Vello CPU, Vello Hybrid, and Skia in addition to Vello. It also allow people to "bring their own renderer" if they have a custom rendering setup they want to support.Changes made
kurboandpenikodirectly rather than throughvellovellodependency. Addanyrenderdependency.render.rs: replacevello::Scenewithimpl anyrender::PaintSceneexamples/scenes/src/lottie.rs: useanyrender_vello::VelloScenePainterto bridge betweenvello::Sceneandanyrender::PaintScene