Integrate rustfmt to generator #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenzV
approved these changes
Jun 19, 2025
fearless_simd_gen/src/main.rs
Outdated
Comment on lines
122
to
132
| fn write_formatted(text: &[u8], out: File) -> std::process::Child { | ||
| let mut child = std::process::Command::new("rustfmt") | ||
| .stdin(std::process::Stdio::piped()) | ||
| .stdout(out) | ||
| .spawn() | ||
| .expect("`rustfmt` command to have spawned"); | ||
| let mut stdin = child.stdin.take().expect("stdin handle to be present"); | ||
| stdin.write_all(text).unwrap(); | ||
| drop(stdin); | ||
| child | ||
| } |
Collaborator
There was a problem hiding this comment.
I feel like the waiting can just happen in the method instead of returning the process and then waiting in main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR follows the recommendation in Zulip of doing what
ashdoes: ash-rs/ash#735Zulip thread: #rust > A plan for SIMD @ 💬
Changes
The first commit contains the logic changes to the CLI. The second commit contains
rustfmt.wasmmodule such that running the CLI with no arguments regenerates WASM.rustfmt.Test plan
Manually ran CLI. No logic changes in the generator (just formatting).