Explicitly cast_signed some masks and sign bits on x86
#190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomcur
force-pushed
the
push-oozwvvuptrsq
branch
from
cf9ea87 to
d9f5880
Compare
Collaborator
|
Is this specific lint not caught in CI? 🤔 Otherwise CI should have failed, no? |
Member
Author
|
It would be caught when we update to lint set v8, it's not included in v6.1 (which |
LaurenzV
approved these changes
Jan 25, 2026
tomcur
force-pushed
the
push-oozwvvuptrsq
branch
from
d9f5880 to
78ec6a4
Compare
Like linebender#186, explicitly reinterpret the bit patterns as signed (i.e., this is explicitly a no-op at the instruction-level). Also uses `cast_signed` for splatting on x86, which just broadcasts the bit pattern. Fixes the remainder of `clippy::cast_possible_wrap` warnings on x86.
tomcur
force-pushed
the
push-oozwvvuptrsq
branch
from
78ec6a4 to
1ebaf09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the remainder of
clippy::cast_possible_wrapwarnings on x86.Very similarly to #186, explicitly reinterpret these bit patterns as signed (i.e., this again is explicitly a no-op at the instruction-level, but effectively checks bit width remains the same). Also uses
cast_signedfor splatting on x86, which just takes the bit pattern as a signed numeric type for broadcasting.