Add clippy to CI (as non blocking warnings) #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
There was a problem hiding this comment.
Sorry for landing this!
LaurenzV
approved these changes
Jun 26, 2025
.github/workflows/ci.yml
Outdated
| # For now, we only check `fearless_simd_gen`, since `fearless_simd` uses `prettyplease`. | ||
| - name: cargo fmt | ||
| run: cd fearless_simd_gen && cargo fmt --check | ||
| run: cargo fmt --check |
Collaborator
There was a problem hiding this comment.
Do we need to pass --all here or does it work just like that?
|
|
||
| [workspace.lints] | ||
|
|
||
| # LINEBENDER LINT SET - Cargo.toml - v5 |
Collaborator
There was a problem hiding this comment.
I'm not sure whether we really want all of those lints as some might become a bit annoying to deal with and unnecessary (see also currently failing CI) since we are dealing with code generation, but I'm okay with leaving it as is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds the Linebender clippy warnings to CI. Because CI doesn't block us it's ok to land. Ideally I'd like all the clippy lints to become errors and for us to burn down the clippy warnings.
I also deleted some embarrassing
println!debug statements that I accidentally merged intomain🤦Finally, I increased the scope of the
fmtcheck to all packages.Goal
In the longer term I think it's important we conform to clippy, if only because it'll catch issues.
As a random note, I couldn't use
fearless_simdwithvellousingbytemuckversion1.23.1, due to conflicting dependencies invello. Using1.23.0matches the version of bytemuck in vello.