[WASM] implement mul_u8x16 and mul_i8x16
#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenzV
approved these changes
Jun 20, 2025
Collaborator
LaurenzV
left a comment
LaurenzV
left a comment
There was a problem hiding this comment.
Haven't looked into how shuffle works, but seems fine!
Collaborator
Author
|
I've added back tests, but kept the tests within bounds as to not exercise overflow logic. |
ajakubowicz-canva
force-pushed
the
ajakubowicz-more-wasm-ops
branch
from
1b18e2c to
19ad0db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mul_u8x16andmul_i8x16are implemented as truncating multiplication, matchingneon.While unit testing this change I noticed that the Fallback level panics on overflow. Opened: https://github.com/raphlinus/fearless_simd/issues/11
A source of inspiration for this implementation was Highway's MulHigh.