Skip to content

CMake and CI refinements #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
scivision wants to merge 4 commits into
base: master
Choose a base branch
from
Open

CMake and CI refinements #44

scivision wants to merge 4 commits into from

Conversation

@scivision
Copy link

@scivision scivision commented Feb 4, 2024 •
edited
Loading

  • CI: remove unused variables
  • CMake >= 3.14 was actually required with the project before this PR
  • use add_compile_options() and add_link_options() rather than edit CMake variables (this is canonical way)
  • simplify and generalize compiler options
  • add labels to tests to allow selection of subsets of tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@scivision