🔥 Remove cookie related logic in embed #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request removes all cookie-related logic from the embed functionality in response to modern browsers blocking third-party cookies in embedded contexts.
Changes:
- Removed
tiny-cookiedependency from both src and functions packages - Removed cookie detection utilities and authentication logic that relied on cookie support
- Simplified embed authentication flow to always use popup-based login instead of conditional logic
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/client.js | Removed cookie storage API access detection functions |
| src/util/api/api.js | Removed cookie support parameter from API call to get user status |
| src/pages/in/embed/_id/button.vue | Simplified doLogin to always use popup, removed unused imports |
| src/package.json | Removed tiny-cookie dependency |
| src/package-lock.json | Removed tiny-cookie package resolution |
| src/mixins/embed.js | Removed cookie support detection logic, data properties, and API parameters |
| src/mixins/embed-button.js | Removed head() function using cookie state, updated mounted to fetch only total count |
| functions/package.json | Removed tiny-cookie dependency |
| functions/package-lock.json | Removed tiny-cookie package resolution |
Files not reviewed (2)
- functions/package-lock.json: Language not supported
- src/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nwingt
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.