Skip to content

Conversation

@williamchong
Copy link
Member

Base on #537

@williamchong williamchong requested review from a team and Copilot September 9, 2025 19:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes register ISCN functions and related mint/NFT functionality from the application. Based on the title and description referencing PR #537, this appears to be a cleanup effort to simplify the application by removing ISCN registration capabilities.

  • Removes server-side crawler functionality and related routes
  • Eliminates mint/NFT related UI components and features from ISCN viewer pages
  • Removes localization strings for mint and NFT functionality
  • Simplifies the main navigation by removing mint-related buttons

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
server/index.ts Removes crawler router import and route registration
pages/view/_iscnId/index.vue Removes mint buttons, edit functionality, and NFT Book Press integration
locales/en.json Removes mint, NFT, and related UI text strings
components/IscnUploadedInfo.vue Removes edit bar and mint functionality from uploaded ISCN info display
components/IscnInfoCard.vue Removes register and mint buttons from the main info card
components/AppHeader.vue Removes mint tab from main navigation
Comments suppressed due to low confidence (1)

components/IscnInfoCard.vue:128

  • This hidden NFT Portal button should be removed entirely rather than hidden with CSS, as it's dead code that will never be shown and references functionality that's being removed.
            'p-[8px]',
            'my-[12px]'
          ]"
        >
        <!-- hidden for now -->
          <Button
            class="hidden"
            preset="primary"
            :text="$t('HomePage.button.nftPortal')"
            :to="localeLocation({ name: 'nft-url' })"
            :style="{ color: '#FFFFFF', backgroundColor: '#C69F67' }"
          >
            <template #prepend>
              <IconAddToISCN class="w-[20px]" />
            </template>
            <template #append>
              <IconArrowRight class="w-[20px]" />
            </template>
          </Button>
        </div>

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -482,8 +453,6 @@ import {
ARWEAVE_ENDPOINT,
} from '~/constant'

Copy link

Copilot AI Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Unused import NFT_BOOK_PRESS_URL was removed but there are empty lines left behind. Consider cleaning up the formatting by removing the extra blank lines.

Suggested change

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@williamchong williamchong merged commit 1fd8646 into likecoin:main Sep 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants