Skip to content

fix: correct USD external account examples to match schema#232

Merged
AaryamanBhute merged 1 commit intomainfrom
fix-linting
Feb 25, 2026
Merged

fix: correct USD external account examples to match schema#232
AaryamanBhute merged 1 commit intomainfrom
fix-linting

Conversation

@AaryamanBhute
Copy link
Contributor

Summary

  • Fixed usBankAccount examples in both customer and platform external account endpoints
  • Changed invalid accountType: US_ACCOUNT to USD_ACCOUNT to match the UsdAccountInfo schema discriminator
  • Added missing required fields countries and paymentRails

Test plan

  • make lint passes with 0 warnings

🤖 Generated with Claude Code

The usBankAccount examples used invalid accountType "US_ACCOUNT" and were
missing required fields. Updated to "USD_ACCOUNT" and added countries and
paymentRails to conform to the UsdAccountInfo schema.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

✱ Stainless preview builds

This PR will update the grid SDKs with the following commit messages.

kotlin

chore(tests): update external account test fixtures from BRL to USD

openapi

feat(api): add countries/paymentRails, update accountType in external accounts

python

chore(tests): update external_accounts test fixtures from BRL/PIX to USD/ACH examples

typescript

chore(internal): update external accounts examples and test fixtures
grid-openapi studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅

grid-python studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅build ✅lint ✅test ✅

pip install https://pkg.stainless.com/s/grid-python/fb7f8946f342ddce489d1ec758d4166109fa0948/grid-0.0.1-py3-none-any.whl
grid-kotlin studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅build ✅lint ✅test ✅

grid-typescript studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅build ✅lint ✅test ✅

npm install https://pkg.stainless.com/s/grid-typescript/56867d5bc8af9d906f094b8abac549038811db34/dist.tar.gz

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-02-25 23:17:13 UTC

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 25, 2026

Greptile Summary

Corrected USD external account examples to match the UsdAccountInfo schema requirements. Changed invalid accountType: US_ACCOUNT to USD_ACCOUNT and added missing required fields countries and paymentRails in both customer and platform external account endpoints.

Changes:

  • Fixed accountType discriminator from US_ACCOUNT to USD_ACCOUNT to match schema enum
  • Added required countries: [US] field
  • Added required paymentRails: [ACH] field
  • Generated bundles (openapi.yaml and mintlify/openapi.yaml) correctly reflect source changes

Note: Similar issues exist in payment instruction examples in openapi/components/schemas/transactions/OutgoingTransaction.yaml, openapi/components/schemas/quotes/Quote.yaml, and openapi/webhooks/outgoing-payment.yaml (still using US_ACCOUNT instead of USD_ACCOUNT). Consider addressing these in a follow-up PR.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • All changes correctly align examples with schema requirements, fixing invalid discriminator value and adding missing required fields. Changes are documentation-only (OpenAPI examples) with no runtime impact. Generated bundles are properly updated.
  • No files require special attention

Important Files Changed

Filename Overview
openapi/paths/customers/customers_external_accounts.yaml Fixed USD account example: corrected accountType to USD_ACCOUNT and added required countries and paymentRails fields
openapi/paths/platform/platform_external_accounts.yaml Fixed USD account example: corrected accountType to USD_ACCOUNT and added required countries and paymentRails fields

Last reviewed commit: 5703552

@AaryamanBhute AaryamanBhute merged commit 088fa66 into main Feb 25, 2026
7 of 8 checks passed
Copy link
Contributor Author

Merge activity

@AaryamanBhute AaryamanBhute deleted the fix-linting branch February 25, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants