Making Rc3 the default now #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted" This reverts commit fec6923.
* Cleanup and rename col/row navigation helpers * Add spatial navigation helpers * Refactor navigation functions to improve selection logic and simplify child focus handling * Fix onGridFocus no scroll issue * Refactor onGridFocus to use optional parameter syntax * Rename getDistanceBetweenRects to getWeightedDistanceBetweenRects and update logic to calculate distances based on center and edge positions. * Enhance navigableForwardFocus to include lastSelected in onSelectedChanged callback * Use findFirstSelectableChildIdx in moveSelection * Refactor selectChild to handle null children and update onSelectedChanged callback * Refactor navigableForwardFocus to simplify focus checking and update selected child logic * Only check for skipfocus for selectable child * Use findFirstFocusableChildIdx in navigableForwardFocus * Add idxInArray to cleanup code * Switch to calculating rect dist from centers * Use new navigable helpers in row and col * Fix selection logic in moveSelection to handle skipFocus correctly * Add jsdoc to navigation helpers * Rename navigable helpers and add examples * Correct calculating child rect Depends on lightning-tv/core#66
Updates `onFocus`, `onBlur`, and `onFocusChanged` callbacks to receive the node triggering the event as the last argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.