Open
Conversation
ekilmer
requested changes
Jul 29, 2022
Comment on lines
+3
to
+6
| REPO lifting-bits/remill | ||
| REF e7c0e3f9f7f482b6bcc336cd98b8afd4129c6e3b | ||
| SHA512 49ee8db4dbf097e89046f3fce3de85ea35703d329f44b3388af992664760044aa8a9e7d0dac1c71e914b0fe0293f5ec10cc8ef4de5e5a118a492b6b2581b9b8c | ||
| HEAD_REF vcpkg-manifest |
Collaborator
There was a problem hiding this comment.
I think I mentioned this already privately, but ideally we use a commit on master branch before merging this
4074180 to
3f87fb1
Compare
Previously, vcpkg would ignore it and just print the heuristically generated usage.
|
Henrich Lauko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Only upgrade ports that are specified. Also, ask the user if they're sure they want to upgrade. It should prevent accidentally deleting/rebuilding LLVM if it's out of date or if trying to upgrade a port it depends on.
- Replace patch `0027-unknown-attrs-as-annotations.patch` with a new patch that also adds the method `AttributedType::getAttr()` to get the type that an `AttributedType` instance is attributed with. - Update `ports/llvm-16/portfile.cmake` to reflect this change.
* Update vcpkg * bump rellic * bump anvill/remill * Cleanup NuGet cache to fix space error on runner * Use anvill patchable-ir-main --------- Co-authored-by: Eric Kilmer <eric.d.kilmer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
remillandgapports.remillport allows to specify featurescxx-common-llvm-14orsystem-llvmto build with local installllvmor usescxx-commonprovided LLVM.