ui: Use standard styled checkboxes in the board editor#19388
ui: Use standard styled checkboxes in the board editor#19388nkc-137 wants to merge 6 commits intolichess-org:masterfrom
Conversation
|
I think this page is more form-like as a whole in its conception so I believe checkboxes are more appropriate for the Editor than toggles are. Will tick off as far as #17396 is concerned. |
| h('div.castling', [ | ||
| h('strong', i18n.site.castling), | ||
| h('div', [ | ||
| castleCheckBox(ctrl, 'K', i18n.site.whiteCastlingKingside, !!ctrl.options.inlineCastling), |
There was a problem hiding this comment.
looks like you dropped that. OK, it wasn't really necessary. But then please delete the now fully unused inlineCastling option
There was a problem hiding this comment.
I removed inlineCastling option from all the places in the recent commits. Thanks for pointing me in the right direction.
| .form-check__label::after { | ||
| width: calc(12px * var(--form-check-scale)); | ||
| height: calc(6px * var(--form-check-scale)); | ||
| border-width: calc(2.5px * var(--form-check-scale)); |
There was a problem hiding this comment.
I see 5 new hardcoded values that will break later when form-check is updated.
Can't you just scale the whole thing without making any new assumptions about it? transform: scale?
There was a problem hiding this comment.
Yes, agreed. I think I can make this better by scaling the whole element using transform: scale(...) so it doesn't break in the future due ot form-check updates.
3 participants
Summary
Use the standard styled checkboxes we recently designed in the board editor. This is a PR for the issue: #17396
###Testing