Draft
Conversation
…ments for pgn output
…that it can be called in both ofChapter(...) and node2move(...), which allows us to print the initial hint
Interactive pgn idempotency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far changes only made in /modules/study/src/main/PgnDump.scala
New Functions are combineComments and gamebookComment.
combineComments was created to reduce duplicate code in the ofChapter(...) and node2moves(...) functions in PgnDump.scala. A more descriptive name might be possible.
gamebookComment was templated after shapeComment, and was created to format gamebookComments (i.e. interactive study comments) for PGN exporting.