Supports mouse right click button for shape creation#70
Open
romaingyh wants to merge 1 commit intolichess-org:mainfrom
Open
Supports mouse right click button for shape creation#70romaingyh wants to merge 1 commit intolichess-org:mainfrom
romaingyh wants to merge 1 commit intolichess-org:mainfrom
Conversation
Collaborator
|
Hello, sorry for the delay, I don't look as often at the notifications in this repo. Will check this asap! |
Collaborator
|
This is low priority for me since we don't really support mouses in lichess app. I'm not sure yet I'll merge this, but it doesn't seem to add a lot of complexity, so probably ok. |
Author
|
Hi, I understand lichess app doesn't use mouse, this PR was more for flutter users looking for a good chess package they could use on desktop or web 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I know even if it works with web-assembly this package isn't made to be used with web, but as macOS Windows and Linux are marked as supported I added the ability to draw shapes using mouse right click.
I didn't run
dart formatbecause It creates many diff in test files, maybe because of new dart formatter since 3.7