Rebase to 0ccd3c84d from upstream

[warmenhoven]

Tested on macOS and iOS so far. I've confirmed that rumble is fixed (fixes #303).

Only marked as a Draft PR for now because I want to run it through the gitlab builders for all of the platforms before actually having this merged, and the gitlab install is currently down.

[warmenhoven]

https://git.libretro.com/libretro/mgba/-/pipelines/326619

[endrift]

Post-merge fixes look fine, though I should probably look into upstreaming them in the long run.

Thanks for taking care of this.

[endrift]

This file is already included on line 6

[warmenhoven]

Yep, thanks, this was left over from when I was working through a compilation error after the ENABLE_VFS changes. I've updated the PR with it removed, and the pipeline of course still passes, https://git.libretro.com/libretro/mgba/-/pipelines/326672.

[warmenhoven]

Post-merge fixes look fine, though I should probably look into upstreaming them in the long run.

When taking a look at the diff between mgba-emu/mgba and libretro/mgba, excluding the new files and changes to libretro.c, most of the changes are pretty small and look to me like they shouldn't be controversial. I can put together a quick PR against mgba-emu/mgba that tries to bring them a little closer together if you'd like.

Thanks for taking care of this.

Thanks for the review!

[MuPendulum]

Thanks for this!

When I did this in July, I ran into a crash when threaded video was enabled which I bisected to 1ca7544 but I never had the time to look further into. I assume it was likely fixed with your android fix in 72b5a9d.

Here were some changes upstream or downstream made that I had spotted back then if anyone wants to try to reduce the difference from upstream:
https://gist.github.com/MuPendulum/c8067e8cbc722cf59690aaf1be44ed23

src/core/CMakeLists.txt

• Scripting support was made optional

src/core/core-serialize.c

• An _MSC_VER check was changed when PS2 support was added and then reverted in a later commit but used a different syntax than upstream

src/gba/sio.c

• These lines in GBASIOInit were removed in 401bc9e but I'm not sure if there's a libretro fork specific reason for keeping them

src/platform/libretro/libretro.c

• endrift refactored the low-pass audio filter when she merged it from downstream in f7d594a
• I'm not sure about the break change for the switch in retro_get_memory_size but it was done during a rebase in a0f0828