Merged
Conversation
Contributor
|
just to make it clear: i have absolutely no authority here, and i'm not sure if my opinion lines up with jdavid.
otherwise good idea to look in the official docs, maybe i should have done this, before randomly typing files. |
Following this doc: https://mypy.readthedocs.io/en/stable/existing_code.html#getting-to-strict Total 13 error fixed.
Don't want to mess with setup.py and types since they are not that important here.
This is a first step according to the documentation https://mypy.readthedocs.io/en/stable/existing_code.html#getting-to-strict
Contributor
Author
done rearranged the commits. Whom can i ping who is the authority here? :) Perhaps @jdavid @BenediktSeidl Also going forward i noticed a lot of C code and ffi C. I have no idea how to type the python code that calls C. Need help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This intoduces a stricter mypy config.
The first step just fixes some unused type ignores.
All according to this doc: https://mypy.readthedocs.io/en/stable/existing_code.html#getting-to-strict
Following the above mentioned doc just becauses i needed some plan of action.
@BenediktSeidl Please take a look.
Comments/suggestions welcome.