Fix black video on VideoPlayerAndroid when fbo size changes. #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a video is played and the
fbosize changes,fbois recreated.The field
frameis set to null and after the firstupdate()call, it is initialized with thefbotexture.If
updateis called beforefbois re-initialized,framewill get the oldfbotexture and it will result into a black screen video.Proposed approach:
Check the
frameagainst the currentfbotexture instead of just checking if it is null.First approach I had:
Remove the
framefield, because we can get the texture directly fromfboand thus fixes the issue (and makes the code less brittle because we don't need to keep updating theframefield anymore). This solution has a caveat that until the first frame is available, the rendered texture will be black.