Fix sslmode=verify-ca verifying the hostname #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arp242
force-pushed
the
verify-ca
branch
2 times, most recently
from
a69e154 to
3bd9714
Compare
This fixes sslmode=verify-ca. The DNSName field is documented as: // DNSName, if set, is checked against the leaf certificate with // Certificate.VerifyHostname or the platform verifier. So the fix is to just remove that field. Took me a while to reproduce; turns out it validates only if DNSNAme is set to a hostname, and not an IP address (which makes sense, as it's not a DNS name). So the tests would pass on account of that. To fix that, also add "postgres-invalid" to /etc/hosts and test that too. Also rewrite the SSL tests to table-driven tests while I'm here. Fixes #1106 Fixes #1164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes sslmode=verify-ca. The DNSName field is documented as:
So the fix is to just remove that field.
Took me a while to reproduce; turns out it validates only if DNSNAme is set to a hostname, and not an IP address (which makes sense, as it's not a DNS name). So the tests would pass on account of that. To fix that, also add "postgres-invalid" to /etc/hosts and test that too.
Also rewrite the SSL tests to table-driven tests while I'm here.
Fixes #1106