[ESP8266] Enable CORS globally

[chromoxdor]

Next try :)

I found out that CORS was only for /json and /metrics enabled. With this change, CORS is now globally enabled for ESP8266 builds, to get the same behavior as in ESP32 builds…

[chromoxdor]

@TD-er: This would be ready to merge too...

[TD-er]

@TD-er: This would be ready to merge too...

Can you have a look at my last question, right above your reply?

[chromoxdor]

Can you have a look at my last question, right above your reply?

You seem to see something I do not. :) What do you mean?

[TD-er]

@chromoxdor

[chromoxdor]

Strange.. I do not see your entry on my side.
But you are right. I removed this part because it resulted in two "allow origin" entries, which the browser complains about then.
There must be a better solution, but I am having trouble fully understanding the code in this regard...
Any help is much appreciated. :)

[tonhuisman]

I removed this part because it resulted in two "allow origin" entries, which the browser complains about then

That's because the true parameter in startStream adds that allow-origin, but also the * origin parameter adds it, after enabling CORS. Setting that first parameter to false solves that 😉

[chromoxdor]

That's because the true parameter in startStream adds that allow-origin, but also the * origin parameter adds it, after enabling CORS. Setting that first parameter to false solves that 😉

Exactly my thinking. But I am not sure if it also affects ESP32 builds since I have struggled to understand. So I got tired of investigating. :)

[chromoxdor]

But I am not sure if it also affects ESP32

So it seems it doesn't
Just tested all and it looks good...