fix: maintain compatibility with Dart SDK 3.2.0+ for Homebrew builds #948
+1,755
−1,144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves Homebrew build failures caused by pubspec_parse 1.5.0 requiring Dart SDK >=3.6.0. The Homebrew formula currently bundles Dart SDK 3.2.6, which is incompatible with the newer constraint. Changes: - Pin pubspec_parse to ">=1.2.0 <1.5.0" to support Dart SDK 3.2.0+ - Simplify pubspec serialization in project_model to essential fields - Remove unused newer pubspec_parse features (executables, funding, topics, screenshots) - Fix ExitCode import conflicts by hiding from mason_logger - Add null-safe environment access for compatibility with older pubspec_parse - Add CI job to test with minimum SDK version (test-min-sdk) - Add script to extract minimum SDK version from pubspec.yaml The test-min-sdk CI job automatically validates compatibility with the minimum declared SDK version, preventing future regressions. Fixes #940
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Remove unused mason_logger imports from api_command and use_command - Update minimum SDK to 3.2.0 (actual minimum required by dependencies) - Keep pubspec_parse constraint below 1.5.0 to avoid SDK 3.6.0 requirement - Ensures compatibility with Homebrew's bundled Dart SDK 3.2.6 Fixes analyzer warnings in test CI and dependency resolution in test-min-sdk job.
- Regenerate pubspec.lock with compatible package versions - file: 6.0.0 -> 7.0.1 (adds exclusive parameter support) - win32: 5.0.7 -> 5.15.0 (fixes UnmodifiableUint8ListView issue) - archive: 3.1.2 -> 3.6.1 (fixes UnmodifiableUint8ListView issue) - Remove dart pub downgrade from test-min-sdk workflow - Fix null-safety warnings in project_model.dart for newer packages The old downgraded packages were incompatible with Dart SDK 3.9.x used in CI. The min-SDK test will resolve its own compatible versions when running with SDK 3.2.0.
Update minimum Dart SDK constraint to 3.8.0 to accommodate cli_pkg 2.14.0 which provides standalone executable support (useExe feature from PR #929). The previous attempt to use SDK 3.2.0 was incompatible with the useExe feature introduced in cli_pkg 2.13.0+. SDK 3.8.0 is still compatible with Homebrew distribution while supporting all required features. Key constraints maintained: - pubspec_parse: <1.5.0 (avoids SDK 3.6.0 requirement) - cli_pkg: 2.14.0 (provides useExe feature) - Dart SDK: >=3.8.0 (supports all dependencies) Resolves merge conflicts with main branch updates from PRs #947 and #949.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves Homebrew build failures caused by
pubspec_parse ^1.5.0requiring Dart SDK >=3.6.0. The Homebrew formula currently bundles Dart SDK 3.2.6, which is incompatible with the newer constraint.Changes Made
Core Fix
pubspec_parseto">=1.2.0 <1.5.0"to support Dart SDK 3.2.0+project_model.dartto essential fields onlypubspec_parsefeatures not available in older versions:executables,funding,topics,screenshotshomepage,repository,issueTracker,documentation,publishTodependencyOverridesCompatibility Improvements
hide ExitCodefrommason_loggerpubspec_parseversionsbuild_runnerCI/Testing
test-min-sdkjob to automatically test with minimum SDK versionscripts/get_min_sdk_version.shhelper scriptImpact
Test Plan
dart pub getwith minimum SDK (3.2.0)dart pub downgradeto test minimum dependenciesdart analyze --fatal-infoswith both min and max dependenciesdart run build_runner buildto regenerate mappersFixes #940