Skip to content

fix: bump native binaries to b8480 (16KB page-aligned)#91

Closed
beniamin-szilagyi wants to merge 1 commit intoleehack:mainfrom
LifeValue:fix/16kb-alignment
Closed

fix: bump native binaries to b8480 (16KB page-aligned)#91
beniamin-szilagyi wants to merge 1 commit intoleehack:mainfrom
LifeValue:fix/16kb-alignment

Conversation

@beniamin-szilagyi
Copy link

Summary

Test plan

  • Build Android AAB and verify with readelf -lW that all LOAD segments have 0x4000 alignment

🤖 Generated with Claude Code

@leehack
Copy link
Owner

leehack commented Mar 23, 2026

@beniamin-szilagyi Wow! I was about to work on this later today, but you were so fast. :) Thanks for the contribution. Do you mind also running ffigen with the version of llama.cpp? You should be able to find the headers in the llamadart-native package.

@beniamin-szilagyi
Copy link
Author

@leehack thanks!

I tried running ffigen locally but I'm on macOS, which produces macOS-specific FILE struct definitions instead of the Linux _IO_FILE in the current bindings.

Could you trigger the Sync Native Version & Bindings workflow with tag b8480? That would generate the correct bindings on Ubuntu.

Happy to help either way.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.90%. Comparing base (c8bfd05) to head (9d02b68).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   76.90%   76.90%           
=======================================
  Files          67       67           
  Lines        8368     8368           
=======================================
  Hits         6435     6435           
  Misses       1933     1933           
Flag Coverage Δ
unittests 76.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leehack
Copy link
Owner

leehack commented Mar 23, 2026

Closing it in favor of #92

@leehack leehack closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants